netdev - Re: [PATCH net-next v2] sections: global data can be in .bss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Nov 2021 11:56:55 -0500
From:   Jonathon Reinhart <jonathon.reinhart@...il.com>
To:     Antoine Tenart <atenart@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, arnd@...db.de,
        Linux Netdev List <netdev@...r.kernel.org>,
        linux-arch@...r.kernel.org, tglx@...utronix.de,
        peterz@...radead.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH net-next v2] sections: global data can be in .bss

On Mon, Nov 22, 2021 at 9:24 AM Antoine Tenart <atenart@...nel.org> wrote:
>
> When checking an address is located in a global data section also check
> for the .bss section as global variables initialized to 0 can be in
> there (-fzero-initialized-in-bss).
>
> This was found when looking at ensure_safe_net_sysctl which was failing
> to detect non-init sysctl pointing to a global data section when the
> data was in the .bss section.
>
> Signed-off-by: Antoine Tenart <atenart@...nel.org>
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Co-Developed-by: Jonathon Reinhart <jonathon.reinhart@...il.com>
Signed-off-by: Jonathon Reinhart <jonathon.reinhart@...il.com>

> ---
>
> A few remarks:
>
> - This still targets net-next but I added Arnd if he prefers to take it
>   through the 'asm-generic' tree, now that is_kernel_core_data is in
>   include/asm-generic/.
>
> - I kept the Acked-by tag as the change is the same really, the
>   difference is the core_kernel_data function was renamed to
>   is_kernel_core_data and moved since then.
>
> - @Jonathon: with your analysis and suggestion I think you should be
>   listed as a co-developer. If that's fine please say so, and reply
>   with both a Co-developed-by and a Signed-off-by tags.

Added, thanks. Although it appears I may have missed the boat.