[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YZuiKw0Q7TU/+lGE@kroah.com>
Date: Mon, 22 Nov 2021 14:59:07 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: Jeremy Kerr <jk@...econstruct.com.au>, netdev@...r.kernel.org,
Matt Johnston <matt@...econstruct.com.au>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH net-next] mctp: Add MCTP-over-serial transport binding
On Mon, Nov 22, 2021 at 01:11:52PM +0000, Matthew Wilcox wrote:
> On Mon, Nov 22, 2021 at 04:23:10PM +0800, Jeremy Kerr wrote:
> > Hi Greg,
> >
> > > ida_destroy() will not be a no-op if you have allocated some things
> > > in the past. It should always be called when your module is removed.
> > >
> > > Or at least that is how it used to be, if this has changed in the
> > > past year, then I am mistaken here.
>
> I think Greg is remembering how the IDA behaved before it was converted
> to use the radix tree back in 2016 (0a835c4f090a). About two-thirds
> of the users of the IDA and IDR forgot to call ida_destroy/idr_destroy,
> so rather than fix those places, I decided to make those data structures
> no longer require a destructor.
Ah, yes. Glad to see that's no longer needed, sorry for the noise and
thanks for correcting me.
greg k-h
Powered by blists - more mailing lists