netdev - Re: [PATCH net] r8169: fix incorrect mac address assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211122183513.0a3f76f6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 22 Nov 2021 18:35:13 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Richard Herbert <rherbert@...patico.ca>
Subject: Re: [PATCH net] r8169: fix incorrect mac address assignment

On Mon, 22 Nov 2021 22:35:33 +0100 Heiner Kallweit wrote:
> The original changes brakes MAC address assignment on older chip
> versions (see bug report [0]), and it brakes random MAC assignment.
> 
> is_valid_ether_addr() requires that its argument is word-aligned.
> Add the missing alignment to array mac_addr.
> 
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215087
> 
> Fixes: 1c5d09d58748 ("ethernet: r8169: use eth_hw_addr_set()")
> Reported-by: Richard Herbert <rherbert@...patico.ca>
> Tested-by: Richard Herbert <rherbert@...patico.ca>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Acked-by: Jakub Kicinski <kuba@...nel.org>

Thanks!