netdev - Re: [RFC 0/2] Add Rx checksum offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b43b2323-e83f-209b-bdff-33c6800d27e3@omp.ru>
Date:   Tue, 23 Nov 2021 18:09:38 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Biju Das <biju.das.jz@...renesas.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        "Biju Das" <biju.das@...renesas.com>
Subject: Re: [RFC 0/2] Add Rx checksum offload support

Hello!

On 23.11.2021 16:31, Biju Das wrote:

> TOE has hw support for calculating IP header checkum for IPV4 and

    hw == hardware? And checksum. :-)

> TCP/UDP/ICMP checksum for both IPV4 and IPV6.
> 
> This patch series aims to adds Rx checksum offload supported by TOE.
> 
> For RX, The result of checksum calculation is attached to last 4byte
> of ethernet frames. First 2bytes is result of IPV4 header checksum
> and next 2 bytes is TCP/UDP/ICMP.
> 
> if frame does not have error "0000" attached to checksum calculation
> result. For unsupported frames "ffff" is attached to checksum calculation
> result. Cases like IPV6, IPV4 header is always set to "FFFF".

    You just said IPv4 header checksum is supported?

> we can test this functionality by the below commands
> 
> ethtool -K eth0 rx on --> to turn on Rx checksum offload
> ethtool -K eth0 rx off --> to turn off Rx checksum offload
> 
> Biju Das (2):
>    ravb: Fillup ravb_set_features_gbeth() stub
>    ravb: Add Rx checksum offload support
> 
>   drivers/net/ethernet/renesas/ravb.h      | 20 +++++++++
>   drivers/net/ethernet/renesas/ravb_main.c | 55 +++++++++++++++++++++++-
>   2 files changed, 74 insertions(+), 1 deletion(-)

    Dave, Jakub, I'll try reviewing these later today.

MBR, Sergey