netdev - vxlan: Possible regression in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Nov 2021 18:13:26 +0100 (CET)
From:   Fabian Frédérick <fabf@...net.be>
To:     davem@...emloft.net, kuba@...nel.org, sbrivio@...hat.com,
        jbenc@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: vxlan: Possible regression in vxlan_rcv()

Hi,

    Last year I sent the following

2ae2904b5bac
("vxlan: don't collect metadata if remote checksum is wrong")


thinking it was an optimization and noticed it was managed in that order 
before patch

f14ecebb3a4e
("vxlan: clean up extension handling on rx")


    I was not able to create some script to test that code and had no 
feedback on it but lately, looking at it again I noticed that metadata 
sequence (if (vxlan_collect_metadata(vs))) was updating skb in 
skb_dst_set(skb, (struct dst_entry *)tun_dst); which was not the case 
during the clean up above.

   Can someone tell me if the update is really ok or how I could check 
that code ?
if VXLAN_F_REMCSUM_RX involves metadata checking I can ask to remove the 
patch.

Best regards,
Fabian