netdev - Re: [PATCH] phy: fix possible double lock calling link changed handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZxrhhm0YdfoJcAu@lunn.ch>
Date:   Tue, 23 Nov 2021 05:18:14 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alessandro B Maurici <abmaurici@...il.com>
Cc:     netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] phy: fix possible double lock calling link changed
 handler

On Mon, Nov 22, 2021 at 11:55:48PM -0300, Alessandro B Maurici wrote:
> From: Alessandro B Maurici <abmaurici@...il.com>
> 
> Releases the phy lock before calling phy_link_change to avoid any worker
> thread lockup. Some network drivers(eg Microchip's LAN743x), make a call to
> phy_ethtool_get_link_ksettings inside the link change handler

I think we need to take a step back here and answer the question, why
does it call phy_ethtool_get_link_ksettings in the link change
handler. I'm not aware of any other MAC driver which does this.

	 Andrew