netdev - Re: [PATCH] net-ipv6: do not allow IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Nov 2021 14:52:27 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Maciej Żenczykowski <zenczykowski@...il.com>
Cc:     Maciej Żenczykowski <maze@...gle.com>,
        Linux Network Development Mailing List 
        <netdev@...r.kernel.org>, Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [PATCH] net-ipv6: do not allow IPV6_TCLASS to muck with tcp's ECN

On Tue, Nov 23, 2021 at 2:32 PM Maciej Żenczykowski
<zenczykowski@...il.com> wrote:
>
> From: Maciej Żenczykowski <maze@...gle.com>
>
> This is to match ipv4 behaviour, see __ip_sock_set_tos()
> implementation at ipv4/ip_sockglue.c:579
>
> void __ip_sock_set_tos(struct sock *sk, int val)
> {
>   if (sk->sk_type == SOCK_STREAM) {
>     val &= ~INET_ECN_MASK;
>     val |= inet_sk(sk)->tos & INET_ECN_MASK;
>   }
>   if (inet_sk(sk)->tos != val) {
>     inet_sk(sk)->tos = val;
>     sk->sk_priority = rt_tos2priority(val);
>     sk_dst_reset(sk);
>   }
> }
>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
>

This makes sense, thanks, even if INET_ECN_dontxmit() would eventually
catch up for non dctcp.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>