netdev - RE: [PATCH net-next 1/3] devlink: Add 'enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR12MB5481668180201E8ED641C779DC609@PH0PR12MB5481.namprd12.prod.outlook.com>
Date:   Tue, 23 Nov 2021 05:17:26 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     Shiraz Saleem <shiraz.saleem@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "mustafa.ismail@...el.com" <mustafa.ismail@...el.com>,
        "jacob.e.keller@...el.com" <jacob.e.keller@...el.com>,
        Jiri Pirko <jiri@...dia.com>,
        Leszek Kaliszczuk <leszek.kaliszczuk@...el.com>
Subject: RE: [PATCH net-next 1/3] devlink: Add 'enable_iwarp' generic device
 param



> From: Tony Nguyen <anthony.l.nguyen@...el.com>
> Sent: Tuesday, November 23, 2021 2:41 AM
> 
> From: Shiraz Saleem <shiraz.saleem@...el.com>
> 
> Add a new device generic parameter to enable and disable iWARP functionality
> on a multi-protocol RDMA device.
> 
> Signed-off-by: Shiraz Saleem <shiraz.saleem@...el.com>
> Tested-by: Leszek Kaliszczuk <leszek.kaliszczuk@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  Documentation/networking/devlink/devlink-params.rst | 3 +++
>  include/net/devlink.h                               | 4 ++++
>  net/core/devlink.c                                  | 5 +++++
>  3 files changed, 12 insertions(+)
> 
> diff --git a/Documentation/networking/devlink/devlink-params.rst
> b/Documentation/networking/devlink/devlink-params.rst
> index 4878907e9232..b7dfe693a332 100644
> --- a/Documentation/networking/devlink/devlink-params.rst
> +++ b/Documentation/networking/devlink/devlink-params.rst
> @@ -109,6 +109,9 @@ own name.
>       - Boolean
>       - When enabled, the device driver will instantiate VDPA networking
>         specific auxiliary device of the devlink device.
> +   * - ``enable_iwarp``
> +     - Boolean
> +     - Enable handling of iWARP traffic in the device.
>     * - ``internal_err_reset``
>       - Boolean
>       - When enabled, the device driver will reset the device on internal diff --git
> a/include/net/devlink.h b/include/net/devlink.h index
> aab3d007c577..e3c88fabd700 100644
> --- a/include/net/devlink.h
> +++ b/include/net/devlink.h
> @@ -485,6 +485,7 @@ enum devlink_param_generic_id {
>  	DEVLINK_PARAM_GENERIC_ID_ENABLE_ETH,
>  	DEVLINK_PARAM_GENERIC_ID_ENABLE_RDMA,
>  	DEVLINK_PARAM_GENERIC_ID_ENABLE_VNET,
> +	DEVLINK_PARAM_GENERIC_ID_ENABLE_IWARP,
> 
>  	/* add new param generic ids above here*/
>  	__DEVLINK_PARAM_GENERIC_ID_MAX,
> @@ -534,6 +535,9 @@ enum devlink_param_generic_id {  #define
> DEVLINK_PARAM_GENERIC_ENABLE_VNET_NAME "enable_vnet"
>  #define DEVLINK_PARAM_GENERIC_ENABLE_VNET_TYPE
> DEVLINK_PARAM_TYPE_BOOL
> 
> +#define DEVLINK_PARAM_GENERIC_ENABLE_IWARP_NAME "enable_iwarp"
> +#define DEVLINK_PARAM_GENERIC_ENABLE_IWARP_TYPE
> DEVLINK_PARAM_TYPE_BOOL
> +
>  #define DEVLINK_PARAM_GENERIC(_id, _cmodes, _get, _set, _validate)	\
>  {									\
>  	.id = DEVLINK_PARAM_GENERIC_ID_##_id,
> 	\
> diff --git a/net/core/devlink.c b/net/core/devlink.c index
> 5ad72dbfcd07..d144a62cbf73 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -4432,6 +4432,11 @@ static const struct devlink_param
> devlink_param_generic[] = {
>  		.name = DEVLINK_PARAM_GENERIC_ENABLE_VNET_NAME,
>  		.type = DEVLINK_PARAM_GENERIC_ENABLE_VNET_TYPE,
>  	},
> +	{
> +		.id = DEVLINK_PARAM_GENERIC_ID_ENABLE_IWARP,
> +		.name = DEVLINK_PARAM_GENERIC_ENABLE_IWARP_NAME,
> +		.type = DEVLINK_PARAM_GENERIC_ENABLE_IWARP_TYPE,
> +	},
>  };
> 
>  static int devlink_param_generic_verify(const struct devlink_param *param)
> --
> 2.31.1
Reviewed-by: Parav Pandit <parav@...dia.com>