netdev - Re: [PATCH net 2/2] net/smc: Ensure the active closing peer first closes clcsock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfab4238-3d76-822c-feee-8463054232aa@linux.ibm.com>
Date:   Tue, 23 Nov 2021 09:36:22 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     Tony Lu <tonylu@...ux.alibaba.com>
Cc:     kuba@...nel.org, davem@...emloft.net, guwen@...ux.alibaba.com,
        netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH net 2/2] net/smc: Ensure the active closing peer first
 closes clcsock

On 23/11/2021 09:25, Tony Lu wrote:
> The side that actively closed socket, it's clcsock doesn't enter
> TIME_WAIT state, but the passive side does it. It should show the same
> behavior as TCP sockets.
> 
> Consider this, when client actively closes the socket, the clcsock in
> server enters TIME_WAIT state, which means the address is occupied and
> won't be reused before TIME_WAIT dismissing. If we restarted server, the
> service would be unavailable for a long time.
> 
> To solve this issue, shutdown the clcsock in [A], perform the TCP active
> close progress first, before the passive closed side closing it. So that
> the actively closed side enters TIME_WAIT, not the passive one.
> 

Thank you, I will pick this up for our next submission to the net tree.