netdev - RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB6795F9F553D1B89E45998A4FE6609@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date:   Tue, 23 Nov 2021 10:39:52 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Peng Fan <peng.fan@....com>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Aisheng Dong <aisheng.dong@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml


Hi Peng,

> -----Original Message-----
> From: Peng Fan <peng.fan@....com>
> Sent: 2021年11月23日 17:29
> To: Joakim Zhang <qiangqing.zhang@....com>; Peng Fan (OSS)
> <peng.fan@....nxp.com>; robh+dt@...nel.org; Aisheng Dong
> <aisheng.dong@....com>; davem@...emloft.net; kuba@...nel.org;
> shawnguo@...nel.org; s.hauer@...gutronix.de
> Cc: kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> <linux-imx@....com>; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org
> Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> 
> > Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> >
> >
> > Hi Peng,
> >
> > Thanks a lot for helping upstream this patch set.
> >
> > For this change, have you run 'make dtbs_check'? I remember that split
> > them to pass dtbs_check when convert it into yaml.
> 
> " arch/arm/boot/dts/imx6dl-nitrogen6x.dt.yaml:
> ethernet@...8000: More than one condition true in oneOf schema: "
> 
> But this is not introduced by my patch, it already there even drop my patch.
> 
> I not see other issues.


For this error: ethernet@...8000: More than one condition true in oneOf schema:

This is caused by ['interrupts'] and ['interrupts-extended'], this should be a common limitation, this is a known warning. 
         'oneOf': [{'required': ['interrupts']},
                   {'required': ['interrupts-extended']}],

After applying this patch, I verified on both arm and arm64 platforms, indeed there is no regression targets to ['compatible']. I am okay with this patch, sorry for this inconvenience.

Best Regards,
Joakim Zhang
> Thanks,
> Peng.
> 
> >
> > Best Regards,
> > Joakim Zhang
> > > -----Original Message-----
> > > From: Peng Fan (OSS) <peng.fan@....nxp.com>
> > > Sent: 2021年11月20日 19:58
> > > To: robh+dt@...nel.org; Aisheng Dong <aisheng.dong@....com>;
> Joakim
> > > Zhang <qiangqing.zhang@....com>; davem@...emloft.net;
> > kuba@...nel.org;
> > > shawnguo@...nel.org; s.hauer@...gutronix.de
> > > Cc: kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> > > <linux-imx@....com>; netdev@...r.kernel.org;
> > > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> > > linux-arm-kernel@...ts.infradead.org; Peng Fan <peng.fan@....com>
> > > Subject: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> > >
> > > From: Peng Fan <peng.fan@....com>
> > >
> > > i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need
> > to
> > > split them into three items.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > ---
> > >  Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
> > >  1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > index eca41443fcce..dbf63a9c2a46 100644
> > > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > @@ -39,9 +39,8 @@ properties:
> > >        - items:
> > >            - enum:
> > >                - fsl,imx7d-fec
> > > -          - const: fsl,imx6sx-fec
> > > -      - items:
> > > -          - const: fsl,imx8mq-fec
> > > +              - fsl,imx8mq-fec
> > > +              - fsl,imx8qm-fec
> > >            - const: fsl,imx6sx-fec
> > >        - items:
> > >            - enum:
> > > @@ -50,9 +49,6 @@ properties:
> > >                - fsl,imx8mp-fec
> > >            - const: fsl,imx8mq-fec
> > >            - const: fsl,imx6sx-fec
> > > -      - items:
> > > -          - const: fsl,imx8qm-fec
> > > -          - const: fsl,imx6sx-fec
> > >        - items:
> > >            - enum:
> > >                - fsl,imx8qxp-fec
> > > --
> > > 2.25.1