netdev - Re: [PATCH net-next] net: bridge: Allow base 16 inputs in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Nov 2021 12:17:43 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, roopa@...dia.com,
        bernard@...o.com, David.Laight@...LAB.COM, mlxsw@...dia.com,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next] net: bridge: Allow base 16 inputs in sysfs

On 24/11/2021 12:11, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> Cited commit converted simple_strtoul() to kstrtoul() as suggested by
> the former's documentation. However, it also forced all the inputs to be
> decimal resulting in user space breakage.
> 
> Fix by setting the base to '0' so that the base is automatically
> detected.
> 
> Before:
> 
>  # ip link add name br0 type bridge vlan_filtering 1
>  # echo "0x88a8" > /sys/class/net/br0/bridge/vlan_protocol
>  bash: echo: write error: Invalid argument
> 
> After:
> 
>  # ip link add name br0 type bridge vlan_filtering 1
>  # echo "0x88a8" > /sys/class/net/br0/bridge/vlan_protocol
>  # echo $?
>  0
> 
> Fixes: 520fbdf7fb19 ("net/bridge: replace simple_strtoul to kstrtol")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---

Thank you for taking care of this.
Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>

>  net/bridge/br_sysfs_br.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
> index 11c490694296..159590d5c2af 100644
> --- a/net/bridge/br_sysfs_br.c
> +++ b/net/bridge/br_sysfs_br.c
> @@ -41,7 +41,7 @@ static ssize_t store_bridge_parm(struct device *d,
>  	if (!ns_capable(dev_net(br->dev)->user_ns, CAP_NET_ADMIN))
>  		return -EPERM;
>  
> -	err = kstrtoul(buf, 10, &val);
> +	err = kstrtoul(buf, 0, &val);
>  	if (err != 0)
>  		return err;
>  
>