netdev - Re: [PATCH net] lan743x: fix deadlock in lan743x_phy_link_status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZ5ara1hQZhjICCy@lunn.ch>
Date:   Wed, 24 Nov 2021 16:30:53 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Bryan Whitehead <bryan.whitehead@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alessandro B Maurici <abmaurici@...il.com>
Subject: Re: [PATCH net] lan743x: fix deadlock in
 lan743x_phy_link_status_change()

On Wed, Nov 24, 2021 at 08:16:25AM +0100, Heiner Kallweit wrote:
> Usage of phy_ethtool_get_link_ksettings() in the link status change
> handler isn't needed, and in combination with the referenced change
> it results in a deadlock. Simply remove the call and replace it with
> direct access to phydev->speed. The duplex argument of 
> lan743x_phy_update_flowcontrol() isn't used and can be removed.
> 
> Fixes: c10a485c3de5 ("phy: phy_ethtool_ksettings_get: Lock the phy for consistency")
> Reported-by: Alessandro B Maurici <abmaurici@...il.com>
> Tested-by: Alessandro B Maurici <abmaurici@...il.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Thanks Heiner

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew