netdev - Re: [PATCH] iwlwifi: pcie: fix a warning / build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wnky55vw.fsf@codeaurora.org>
Date:   Wed, 24 Nov 2021 10:12:35 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Adam Borowski <kilobyte@...band.pl>
Cc:     Luca Coelho <luciano.coelho@...el.com>,
        Johannes Berg <johannes.berg@...el.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: pcie: fix a warning / build failure

Adam Borowski <kilobyte@...band.pl> writes:

> drivers/net/wireless/intel/iwlwifi/pcie/drv.c:
>         In function ‘iwl_pci_find_dev_info’:
> ./include/linux/kernel.h:46:25: error: overflow in conversion from
>         ‘long unsigned int’ to ‘int’ changes value from
>         ‘18446744073709551615’ to ‘-1’ [-Werror=overflow]
>
> Signed-off-by: Adam Borowski <kilobyte@...band.pl>
> ---
> Another option would be to #ifdef away iwl_pci_find_dev_info().
>
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> index c574f041f096..81e8f2fc4982 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> @@ -1341,7 +1341,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
>  {
>  	int i;
>  
> -	for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
> +	for (i = (int)ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
>  		const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
>  
>  		if (dev_info->device != (u16)IWL_CFG_ANY &&

There's already fix for this:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=fe785f56ad5886c08d1cadd9e8b4e1ff6a1866f6

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches