netdev - Re: [PATCH net-next v2 3/6] net: lan966x: add port module support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZ+kvpCmWomKNr9l@lunn.ch>
Date:   Thu, 25 Nov 2021 15:59:10 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
        UNGLinuxDriver@...rochip.com, p.zabel@...gutronix.de,
        linux@...linux.org.uk, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/6] net: lan966x: add port module support

> If I undestood you correctly I have tried to do the following:
> 
> struct lan966x_ifh {
>     __be32 timestamp;
>     __be32 bypass : 1;
>     __be32 port : 3;
>     ...
> };
> 
> But then I start to get errors from sparse:
> 
> error: invalid bitfield specifier for type restricted __be32.

Maybe look at struct iphdr. It has bitfields for the header length and
the IP version.

    Andrew