netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Disable AN on 2500base-x for Amethyst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZ+txKp0sAOjQUka@lunn.ch>
Date:   Thu, 25 Nov 2021 16:37:40 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>,
        Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Disable AN on 2500base-x for
 Amethyst

On Thu, Nov 25, 2021 at 03:43:59PM +0100, Marek Behún wrote:
> Amethyst does not support autonegotiation in 2500base-x mode.

Hi Marek

I tried to avoid using Marvells internal names for these devices. I
don't think these names exist in the datasheet? They are visible in
the SDK, but that is not so widely available. So if you do want to use
these names, please also reference the name we use in the kernel,
mv88e6393x.

> It does not link with AN enabled with other devices.
> Disable autonegotiation for Amethyst in 2500base-x mode.
> 
> +int mv88e6393x_serdes_pcs_config(struct mv88e6xxx_chip *chip, int port,
> +				 int lane, unsigned int mode,
> +				 phy_interface_t interface,
> +				 const unsigned long *advertise)
> +{
> +	if (interface == PHY_INTERFACE_MODE_2500BASEX)
> +		return 0;
> +
> +	return mv88e6390_serdes_pcs_config(chip, port, lane, mode, interface,
> +					   advertise);
> +}

What happens when changing from say 1000BaseX to 2500BaseX? Do you
need to disable the advertisement which 1000BaseX might of enabled?

     Andrew