netdev - Re: [PATCH net-next] sctp: make the raise timer more simple and accurate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaABXM/RBXaB8fzN@t14s.localdomain>
Date:   Thu, 25 Nov 2021 18:34:20 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH net-next] sctp: make the raise timer more simple and
 accurate

On Wed, Nov 24, 2021 at 02:26:14PM -0500, Xin Long wrote:
> Currently, the probe timer is reused as the raise timer when PLPMTUD is in
> the Search Complete state. raise_count was introduced to count how many
> times the probe timer has timed out. When raise_count reaches to 30, the
> raise timer handler will be triggered.
> 
> During the whole processing above, the timer keeps timing out every probe_
> interval. It is a waste for the Search Complete state, as the raise timer
> only needs to time out after 30 * probe_interval.
> 
> Since the raise timer and probe timer are never used at the same time, it
> is no need to keep probe timer 'alive' in the Search Complete state. This
> patch to introduce sctp_transport_reset_raise_timer() to start the timer
> as the raise timer when entering the Search Complete state. When entering
> the other states, sctp_transport_reset_probe_timer() will still be called
> to reset the timer to the probe timer.
> 
> raise_count can be removed from sctp_transport as no need to count probe
> timer timeout for raise timer timeout. last_rtx_chunks can be removed as
> sctp_transport_reset_probe_timer() can be called in the place where asoc
> rtx_data_chunks is changed.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>