netdev - Re: [PATCH net-next 1/2] ifb: support ethtools driver info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211124181858.6c4668db@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 24 Nov 2021 18:18:58 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     xiangxia.m.yue@...il.com
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/2] ifb: support ethtools driver info

On Thu, 25 Nov 2021 10:01:54 +0800 xiangxia.m.yue@...il.com wrote:
> +#define DRV_NAME	"ifb"
> +#define DRV_VERSION	"1.0"

Let's not invent meaningless driver versions.

> +#define TX_Q_LIMIT	32
> +
>  struct ifb_q_private {
>  	struct net_device	*dev;
>  	struct tasklet_struct   ifb_tasklet;
> @@ -181,6 +185,12 @@ static int ifb_dev_init(struct net_device *dev)
>  	return 0;
>  }
>  
> +static void ifb_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
> +{
> +	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));

Can we make core fill in driver name from rtnl_link_ops so we don't
need to do it in each driver?

> +	strlcpy(info->version, DRV_VERSION, sizeof(info->version));

Leave this field as is, core should fill it with the kernel release.

> +}