netdev - Re: [PATCH] net-ipv6: changes to ->tclass (via IPV6_TCLASS) should sk_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211124190125.494f62ab@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 24 Nov 2021 19:01:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Maciej Żenczykowski <zenczykowski@...il.com>
Cc:     Maciej Żenczykowski <maze@...gle.com>,
        Linux Network Development Mailing List 
        <netdev@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [PATCH] net-ipv6: changes to ->tclass (via IPV6_TCLASS) should
 sk_dst_reset()

On Tue, 23 Nov 2021 14:32:08 -0800 Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> This is to match ipv4 behaviour, see __ip_sock_set_tos()
> implementation.
> 
> Technically for ipv6 this might not be required because normally we
> do not allow tclass to influence routing, yet the cli tooling does
> support it:
> 
> lpk11:~# ip -6 rule add pref 5 tos 45 lookup 5
> lpk11:~# ip -6 rule
> 5:      from all tos 0x45 lookup 5
> 
> and in general dscp/tclass based routing does make sense.
> 
> We already have cases where dscp can affect vlan priority and/or
> transmit queue (especially on wifi).
> 
> So let's just make things match.  Easier to reason about and no harm.
> 
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>

Please send related patches as a series. There are dependencies here
which prevent the build bot from doing its job (plus it's less work 
for me since I apply by series :)).