netdev - Re: [PATCH net v3] net/smc: Don't call clcsock shutdown twice when smc shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c6804b0-7f3a-0572-42f5-c72ca5dcdc46@linux.ibm.com>
Date:   Fri, 26 Nov 2021 10:04:29 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     Tony Lu <tonylu@...ux.alibaba.com>
Cc:     kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net v3] net/smc: Don't call clcsock shutdown twice when
 smc shutdown

On 26/11/2021 03:41, Tony Lu wrote:
> When applications call shutdown() with SHUT_RDWR in userspace,
> smc_close_active() calls kernel_sock_shutdown(), and it is called
> twice in smc_shutdown().
> 
> This fixes this by checking sk_state before do clcsock shutdown, and
> avoids missing the application's call of smc_shutdown().
> 
> Link: https://lore.kernel.org/linux-s390/1f67548e-cbf6-0dce-82b5-10288a4583bd@linux.ibm.com/
> Fixes: 606a63c9783a ("net/smc: Ensure the active closing peer first closes clcsock")
> Signed-off-by: Tony Lu <tonylu@...ux.alibaba.com>
> Reviewed-by: Wen Gu <guwen@...ux.alibaba.com>
> ---

Acked-by: Karsten Graul <kgraul@...ux.ibm.com>