netdev - Re: [PATCH 2/2] dsa: mv88e6xxx: make serdes SGMII/Fiber output amplitude configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaEIVQ6gKOSD1Vf/@lunn.ch>
Date:   Fri, 26 Nov 2021 17:16:21 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Holger Brunck <holger.brunck@...achienergy.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH 2/2] dsa: mv88e6xxx: make serdes SGMII/Fiber output
 amplitude configurable

> +	if (chip->info->ops->serdes_set_out_amplitude && np) {
> +		if (!of_property_read_u32(np, "serdes-output-amplitude",
> +					  &out_amp)) {
> +			err = mv88e6352_serdes_set_out_amplitude(chip, out_amp);
> +			if (err)
> +				goto unlock;
> +		}
> +	}

If the property is in DT, but the device does not have a
ops->serdes_set_out_amplitude(), please return -EOPNOTSUP.  We want to
avoid the case somebody wrongly cut/pastes a DT fragment to a
different switch.

	  Andrew