netdev - Re: [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211125190101.63f1f0a2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 25 Nov 2021 19:01:01 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Po Liu <po.liu@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Antoine Tenart <atenart@...nel.org>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        "Y.B. Lu" <yangbo.lu@....com>, Rui Sousa <rui.sousa@....com>,
        Richard Cochran <richardcochran@...il.com>,
        "Allan W . Nielsen" <allan.nielsen@...rochip.com>
Subject: Re: [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches

On Thu, 25 Nov 2021 23:45:21 +0000 Vladimir Oltean wrote:
> On Fri, Nov 26, 2021 at 01:21:14AM +0200, Vladimir Oltean wrote:
> > Po Liu reported recently that timestamping PTP over IPv4 is broken using
> > the felix driver on NXP LS1028A. This has been known for a while, of
> > course, since it has always been broken. The reason is because IP PTP
> > packets are currently treated as unknown IP multicast, which is not
> > flooded to the CPU port in the ocelot driver design, so packets don't
> > reach the ptp4l program.
> > 
> > The series solves the problem by installing packet traps per port when
> > the timestamping ioctl is called, depending on the RX filter selected
> > (L2, L4 or both).
> 
> I don't know why I targeted these patches to "net-next". Habit I guess.
> Nonetheless, they apply equally well to "net", can they be considered
> for merging there without me resending?

Only patch 1 looks like a fix, tho? Patch 4 seems to fall into 
the "this never worked and doesn't cause a crash" category.

I'm hoping to send a PR tomorrow, so if you resend quickly it 
will be in net-next soon.