netdev - AW: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PA4P190MB1390D5F29BEAF13BC3B25097D9649@PA4P190MB1390.EURP190.PROD.OUTLOOK.COM>
Date:   Sat, 27 Nov 2021 10:36:53 +0000
From:   Sven Schuchmann <schuchmann@...leissheimer.de>
To:     Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>
CC:     Woojung Huh <woojung.huh@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: AW: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL
 instead of "0" if no IRQ is available

Hello Jakub,

> Von: Jakub Kicinski <kuba@...nel.org>
> Gesendet: Freitag, 26. November 2021 20:35
> An: Andrew Lunn <andrew@...n.ch>; Sven Schuchmann <schuchmann@...leissheimer.de>
> Cc: Woojung Huh <woojung.huh@...rochip.com>; UNGLinuxDriver@...rochip.com; David S. Miller
> <davem@...emloft.net>; netdev@...r.kernel.org; linux-usb@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Betreff: Re: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if
> no IRQ is available
> 
> On Fri, 26 Nov 2021 16:57:50 +0100 Andrew Lunn wrote:
> > On Fri, Nov 26, 2021 at 04:20:40PM +0100, Sven Schuchmann wrote:
> > > On most systems request for IRQ 0 will fail, phylib will print an error message
> > > and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ
> > > is available.
> > >
> > > Signed-off-by: Sven Schuchmann <schuchmann@...leissheimer.de>
> >
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
> 
> right?

Seems right, will send a v2

Sven