netdev - Re: [PATCH iproute2] ip route: save: exclude rtnh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaN/khA2eJJLgdte@shredder>
Date:   Sun, 28 Nov 2021 15:09:38 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Alexander Mikhalitsyn <alexander.mikhalitsyn@...tuozzo.com>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Ido Schimmel <idosch@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Roopa Prabhu <roopa@...dia.com>,
        Andrei Vagin <avagin@...il.com>,
        Pavel Tikhomirov <ptikhomirov@...tuozzo.com>,
        Alexander Mikhalitsyn <alexander@...alicyn.com>
Subject: Re: [PATCH iproute2] ip route: save: exclude rtnh_flags which can't
 be set

On Fri, Nov 26, 2021 at 04:43:10PM +0300, Alexander Mikhalitsyn wrote:
> +	/*
> +	 * Exclude flags which can't be set directly
> +	 * by the userspace from the rtmsg dump.
> +	 */

I believe iproute2 is following netdev style comments [1] so this should
be:

/* Exclude flags which can't be set directly
 * by the userspace from the rtmsg dump.
 */

At least it's consistent with other comments in the file.

[1] https://www.kernel.org/doc/html/v5.12/networking/netdev-FAQ.html#is-the-comment-style-convention-different-for-the-networking-content

> +	r->rtm_flags &= ~RTNH_REJECT_MASK;
> +
>  	ret = write(STDOUT_FILENO, n, n->nlmsg_len);
>  	if ((ret > 0) && (ret != n->nlmsg_len)) {
>  		fprintf(stderr, "Short write while saving nlmsg\n");
> -- 
> 2.31.1
>