netdev - Re: [PATCH nf] vrf: don't run conntrack on vrf with !dflt qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75f4ceed-b556-42ca-0a87-0bc0539139bb@gmail.com>
Date:   Sun, 28 Nov 2021 11:59:23 -0700
From:   David Ahern <dsahern@...il.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>, fw@...len.de,
        pablo@...filter.org
Cc:     lschlesinger@...venets.com, dsahern@...nel.org,
        crosser@...rage.org, netfilter-devel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH nf] vrf: don't run conntrack on vrf with !dflt qdisc

On 11/26/21 7:36 AM, Nicolas Dichtel wrote:
> After the below patch, the conntrack attached to skb is set to "notrack" in
> the context of vrf device, for locally generated packets.
> But this is true only when the default qdisc is set to the vrf device. When
> changing the qdisc, notrack is not set anymore.
> In fact, there is a shortcut in the vrf driver, when the default qdisc is
> set, see commit dcdd43c41e60 ("net: vrf: performance improvements for
> IPv4") for more details.
> 
> This patch ensures that the behavior is always the same, whatever the qdisc
> is.
> 
> To demonstrate the difference, a new test is added in conntrack_vrf.sh.
> 
> Fixes: 8c9c296adfae ("vrf: run conntrack only in context of lower/physdev for locally generated packets")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
>  drivers/net/vrf.c                             |  8 ++---
>  .../selftests/netfilter/conntrack_vrf.sh      | 30 ++++++++++++++++---
>  2 files changed, 30 insertions(+), 8 deletions(-)
> 


Good catch. Thanks, Nicolas.

Reviewed-by: David Ahern <dsahern@...nel.org>