netdev - Re: [PATCH net v2 1/3] net: ipv6: add fib6_nh_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89face48-9b1b-fc0a-2ae2-212bbb1c5af6@gmail.com>
Date:   Sun, 28 Nov 2021 14:35:49 -0700
From:   David Ahern <dsahern@...il.com>
To:     Nikolay Aleksandrov <nikolay@...dia.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        netdev@...r.kernel.org
Cc:     idosch@...sch.org, davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH net v2 1/3] net: ipv6: add fib6_nh_release_dsts stub

On 11/28/21 1:14 PM, Nikolay Aleksandrov wrote:
> It duplicates a part of it but in a safe way because the fib6_nh could still be visible,
> while fib6_nh_release does it in a way that assumes it's not. I could re-use
> this helper in fib6_nh_release though, since it doesn't matter how the entries are
> freed there. I'm guessing that is what you meant?

yes, that is what I meant - it duplicates a chunk of the code in
fib6_nh_release.

> I'll take care of that and of the few possible optimizations for nexthop in net-next.

thanks!