[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87y257ot47.fsf@nvidia.com>
Date: Mon, 29 Nov 2021 16:54:00 +0100
From: Petr Machata <petrm@...dia.com>
To: Petr Machata <petrm@...dia.com>
CC: Jakub Kicinski <kuba@...nel.org>, Ido Schimmel <idosch@...sch.org>,
Toke Høiland-Jørgensen <toke@...hat.com>,
"Alexander Lobakin" <alexandr.lobakin@...el.com>,
Daniel Borkmann <daniel@...earbox.net>,
"David S. Miller" <davem@...emloft.net>,
"Jesse Brandeburg" <jesse.brandeburg@...el.com>,
Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
Jonathan Corbet <corbet@....net>,
"Shay Agroskin" <shayagr@...zon.com>,
Arthur Kiyanovski <akiyano@...zon.com>,
"David Arinzon" <darinzon@...zon.com>,
Noam Dagan <ndagan@...zon.com>,
"Saeed Bishara" <saeedb@...zon.com>,
Ioana Ciornei <ioana.ciornei@....com>,
"Claudiu Manoil" <claudiu.manoil@....com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Marcin Wojtas <mw@...ihalf.com>,
Russell King <linux@...linux.org.uk>,
Saeed Mahameed <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>,
Alexei Starovoitov <ast@...nel.org>,
Jesper Dangaard Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
Edward Cree <ecree.xilinx@...il.com>,
"Martin Habets" <habetsm.xilinx@...il.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Andrii Nakryiko <andrii@...nel.org>,
"Martin KaFai Lau" <kafai@...com>,
Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
KP Singh <kpsingh@...nel.org>,
Lorenzo Bianconi <lorenzo@...nel.org>,
Yajun Deng <yajun.deng@...ux.dev>,
Sergey Ryazanov <ryazanov.s.a@...il.com>,
David Ahern <dsahern@...nel.org>,
Andrei Vagin <avagin@...il.com>,
Johannes Berg <johannes.berg@...el.com>,
"Vladimir Oltean" <vladimir.oltean@....com>,
Cong Wang <cong.wang@...edance.com>, <netdev@...r.kernel.org>,
<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-rdma@...r.kernel.org>, <bpf@...r.kernel.org>,
<virtualization@...ts.linux-foundation.org>, <nikolay@...dia.com>
Subject: Re: [PATCH v2 net-next 21/26] ice: add XDP and XSK generic
per-channel statistics
Petr Machata <petrm@...dia.com> writes:
> Jakub Kicinski <kuba@...nel.org> writes:
>
>> On Sun, 28 Nov 2021 19:54:53 +0200 Ido Schimmel wrote:
>>> # ip stats set dev swp1 hw_stats on
>>
>> Does it belong on the switch port? Not the netdev we want to track?
>
> Yes, it does, and is designed that way. That was just muscle memory
> typing that "swp1" above :)
And by "yes, it does", I obviously meant "no, it doesn't". It does
belong to the device that you want counters for.
> You would do e.g. "ip stats set dev swp1.200 hw_stats on" or, "dev br1",
> or something like that.
Powered by blists - more mailing lists