netdev - Re: [PATCH net-next 01/12] iavf: restore MSI state on reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Nov 2021 18:41:14 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     "Williams, Mitch A" <mitch.a.williams@...el.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>
Subject: Re: [PATCH net-next 01/12] iavf: restore MSI state on reset

On Wed, 2021-11-24 at 15:42 -0800, Jakub Kicinski wrote:
> On Wed, 24 Nov 2021 09:16:41 -0800 Tony Nguyen wrote:
> > If the PF experiences an FLR, the VF's MSI and MSI-X configuration
> > will
> > be conveniently and silently removed in the process. When this
> > happens,
> > reset recovery will appear to complete normally but no traffic will
> > pass. The netdev watchdog will helpfully notify everyone of this
> > issue.
> > 
> > To prevent such public embarrassment, restore MSI configuration at
> > every
> > reset. For normal resets, this will do no harm, but for VF resets
> > resulting from a PF FLR, this will keep the VF working.
> 
> Why is this not a fix?

As I'll need to do a v2 on this series, I'll go ahead and drop it here
and send it via net.

Thanks,
Tony