netdev - Re: [PATCH net-next v2 2/2] bpf: let bpf_warn_invalid_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211129071257.302c6c0e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 29 Nov 2021 07:12:57 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, bpf@...r.kernel.org,
        Toke Høiland-Jørgensen 
        <toke@...hat.com>
Subject: Re: [PATCH net-next v2 2/2] bpf: let bpf_warn_invalid_xdp_action()
 report more info

On Mon, 29 Nov 2021 15:56:33 +0100 Paolo Abeni wrote:
> On Fri, 2021-11-26 at 19:57 +0100, Paolo Abeni wrote:
> > On Fri, 2021-11-26 at 10:19 -0800, Jakub Kicinski wrote:  
> > > Since we have to touch all the drivers each time the prototype of this
> > > function is changed - would it make sense to pass in rxq instead? It has
> > > more info which may become useful at some point.  
> > 
> > I *think* for this specific scenario the device name provides all the
> > necessary info - the users need to know the driver causing the issue.
> > 
> > Others similar xdp helpers - e.g. trace_xdp_exception() - have the same
> > arguments list used here. If the rxq is useful I guess we will have to
> > change even them, and touch all the drivers anyway.  
> 
> Following the above reasoning I'm going to post v3 with the same
> argument list used here, unless someone stops me soon ;)

It's fine, it was just a thought :)