netdev - Re: [PATCH net-next] selftests: net: bridge: fix typo in vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41088611-712e-3f31-cf44-de50359ceccc@nvidia.com>
Date:   Mon, 29 Nov 2021 12:01:20 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: net: bridge: fix typo in
 vlan_filtering dependency test

On 29/11/2021 11:58, Ivan Vecera wrote:
> Prior patch:
> ]# TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh
> TEST: Vlan multicast snooping enable                                [ OK ]
> Device "bridge" does not exist.
> TEST: Disable multicast vlan snooping when vlan filtering is disabled   [FAIL]
>         Vlan filtering is disabled but multicast vlan snooping is still enabled
> 
> After patch:
> # TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh
> TEST: Vlan multicast snooping enable                                [ OK ]
> TEST: Disable multicast vlan snooping when vlan filtering is disabled   [ OK ]
> 
> Fixes: f5a9dd58f48b7c ("selftests: net: bridge: add test for vlan_filtering dependency")
> Cc: Nikolay Aleksandrov <nikolay@...dia.com>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---
>  tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> index 5224a5a8595b32..8748d1b1d95b71 100755
> --- a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> +++ b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> @@ -527,7 +527,7 @@ vlmc_filtering_test()
>  {
>  	RET=0
>  	ip link set dev br0 type bridge vlan_filtering 0
> -	ip -j -d link show dev bridge | \
> +	ip -j -d link show dev br0 | \
>  	jq -e "select(.[0].linkinfo.info_data.mcast_vlan_snooping == 1)" &>/dev/null
>  	check_fail $? "Vlan filtering is disabled but multicast vlan snooping is still enabled"
>  	log_test "Disable multicast vlan snooping when vlan filtering is disabled"
> 

Good catch, thanks! I've also prepared a few fixes and improvements for the tests,
I'll send them out this week. :)

Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>