netdev - RE: [PATCH bpf-next 4/4] samples/bpf: xdpsock: add time-out for cleaning Tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Nov 2021 01:17:39 +0000
From:   "Ong, Boon Leong" <boon.leong.ong@...el.com>
To:     Jesper Dangaard Brouer <jbrouer@...hat.com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "brouer@...hat.com" <brouer@...hat.com>,
        "bjorn@...nel.org" <bjorn@...nel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Jonathan Lemon" <jonathan.lemon@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Jesper Dangaard Brouer" <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        "Andrii Nakryiko" <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>
Subject: RE: [PATCH bpf-next 4/4] samples/bpf: xdpsock: add time-out for
 cleaning Tx

>>   static void complete_tx_only_all(void)
>>   {
>> +	u32 retries = 3;
>>   	bool pending;
>>   	int i;
>>
>> @@ -1421,7 +1422,8 @@ static void complete_tx_only_all(void)
>>   				pending = !!xsks[i]->outstanding_tx;
>>   			}
>>   		}
>> -	} while (pending);
>> +		sleep(opt_interval);
>
>Why/how is this connected with the 'opt_interval' ?
>
>(Which is used by the pthtread 'poller' dumping stats)
>
The original thought was to use the poller interval since
it is what user would experience from terminal. In next rev,
I plan to make it configurable with second granularity as
suggested by Song Liu.

Thanks