netdev - Re: [PATCH net v2 3/3] net: dsa: rtl8365mb: set RGMII RX delay in steps of 0.3 ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaTO2hO2/vPbijCu@lunn.ch>
Date:   Mon, 29 Nov 2021 14:00:10 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alvin Šipraga <alvin@...s.dk>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        linus.walleij@...aro.org, f.fainelli@...il.com, olteanv@...il.com,
        vivien.didelot@...il.com, hkallweit1@...il.com,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Arınç ÜNAL <arinc.unal@...nc9.com>
Subject: Re: [PATCH net v2 3/3] net: dsa: rtl8365mb: set RGMII RX delay in
 steps of 0.3 ns

On Mon, Nov 29, 2021 at 11:30:19AM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@...g-olufsen.dk>
> 
> A contact at Realtek has clarified what exactly the units of RGMII RX
> delay are. The answer is that the unit of RX delay is "about 0.3 ns".
> Take this into account when parsing rx-internal-delay-ps by
> approximating the closest step value. Delays of more than 2.1 ns are
> rejected.
> 
> This obviously contradicts the previous assumption in the driver that a
> step value of 4 was "about 2 ns", but Realtek also points out that it is
> easy to find more than one RX delay step value which makes RGMII work.
> 
> Fixes: 4af2950c50c8 ("net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC")
> Cc: Arınç ÜNAL <arinc.unal@...nc9.com>
> Signed-off-by: Alvin Šipraga <alsi@...g-olufsen.dk>
> Acked-by: Arınç ÜNAL <arinc.unal@...nc9.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew