netdev - Re: [PATCH bpf-next v3 0/2] clean-up for BPF_LOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <915a9acd-1831-2470-1490-ec8af4770e28@huawei.com>
Date:   Tue, 30 Nov 2021 19:48:36 +0800
From:   Hou Tao <houtao1@...wei.com>
To:     Alexei Starovoitov <ast@...nel.org>
CC:     Martin KaFai Lau <kafai@...com>, Yonghong Song <yhs@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, <netdev@...r.kernel.org>,
        <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v3 0/2] clean-up for BPF_LOG_KERNEL log level

Hi Alexei,

Could you please pick the patchset for v5.16 ?

On 11/2/2021 6:15 PM, Hou Tao wrote:
> Hi,
>
> There are just two clean-up patches for BPF_LOG_KERNEL log level:
> patch #1 fixes the possible extra newline for bpf_log() and removes
> the unnecessary calculation and truncation, and patch #2 disallows
> BPF_LOG_KERNEL log level for bpf_btf_load().
>
> Comments are welcome.
>
> Regards,
> Tao
>
> Change Log:
> v3:
>   * rebased on bpf-next
>   * address comments from Daniel Borkmann:
>     patch #1: add prefix "BPF: " instead of "BPF:" for error message
>     patch #2: remove uncessary parenthesis, keep the max buffer length
>               setting of btf verifier, and add Fixes tag.
>
> v2: https://www.spinics.net/lists/bpf/msg48809.html
>   * rebased on bpf-next
>   * patch #1: add a trailing newline if needed (suggested by Martin)
>   * add patch #2
>  
> v1: https://www.spinics.net/lists/bpf/msg48550.html
>
> Hou Tao (2):
>   bpf: clean-up bpf_verifier_vlog() for BPF_LOG_KERNEL log level
>   bpf: disallow BPF_LOG_KERNEL log level for bpf(BPF_BTF_LOAD)
>
>  include/linux/bpf_verifier.h |  7 +++++++
>  kernel/bpf/btf.c             |  3 +--
>  kernel/bpf/verifier.c        | 16 +++++++++-------
>  3 files changed, 17 insertions(+), 9 deletions(-)
>