netdev - Re: [PATCH net-next 2/3] net: prestera: add counter HW API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB400911740A1A73962CF5531EB2679@SJ0PR18MB4009.namprd18.prod.outlook.com>
Date:   Tue, 30 Nov 2021 12:28:27 +0000
From:   "Volodymyr Mytnyk [C]" <vmytnyk@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        "Taras Chornyi [C]" <tchornyi@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Serhiy Boiko <serhiy.boiko@...vell.com>
Subject: Re: [PATCH net-next 2/3] net: prestera: add counter HW API

> On Tue, 23 Nov 2021 18:58:01 +0200 Volodymyr Mytnyk wrote:
> > +     block = prestera_counter_block_lookup_not_full(counter, client);
> > +     if (!block) {
> 
> if (block)
>         return block;

Fixed in v2, thanks.

> 
> > +             block = kzalloc(sizeof(*block), GFP_KERNEL);
> > +             if (!block)
> > +                     return ERR_PTR(-ENOMEM);
> > +
> > +             err = prestera_hw_counter_block_get(counter->sw, client,
> > +                                                 &block->id, &block->offset,
> > +                                                 &block->num_counters);
> 

Regards,
  Volodymyr