netdev - Re: [PATCH net-next v2] net: ipv6: use the new fib6_nh_release_dsts helper in fib6_nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87b2b35e-11b0-4ff8-f65c-9bbef0ab6588@gmail.com>
Date:   Mon, 29 Nov 2021 18:35:09 -0700
From:   David Ahern <dsahern@...il.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org,
        Nikolay Aleksandrov <nikolay@...dia.com>
Subject: Re: [PATCH net-next v2] net: ipv6: use the new fib6_nh_release_dsts
 helper in fib6_nh_release

On 11/29/21 8:44 AM, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@...dia.com>
> 
> We can remove a bit of code duplication by reusing the new
> fib6_nh_release_dsts helper in fib6_nh_release. Their only difference is
> that fib6_nh_release's version doesn't use atomic operation to swap the
> pointers because it assumes the fib6_nh is no longer visible, while
> fib6_nh_release_dsts can be used anywhere.
> 
> Suggested-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...dia.com>
> ---
> v2: no need to check for NULL rt6i_pcpu before calling free_percpu
> 
>  net/ipv6/route.c | 20 ++------------------
>  1 file changed, 2 insertions(+), 18 deletions(-)
> 



Reviewed-by: David Ahern <dsahern@...nel.org>