netdev - Re: Reference to non-existing symbol WAR_R10000 in arch/mips/net/bpf_jit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM1=_QQBfO_RQuYFrhdvZeM+KbY+5w=YVHTfb-zZQsN4fiBMcw@mail.gmail.com>
Date:   Tue, 30 Nov 2021 14:57:21 +0100
From:   Johan Almbladh <johan.almbladh@...finetworks.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Reference to non-existing symbol WAR_R10000 in arch/mips/net/bpf_jit_comp.h

Hi Lukas,

On Mon, Nov 29, 2021 at 7:39 AM Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
>
> Dear Johan,
>
> In arch/mips/net/bpf_jit_comp.h and introduced with commit commit
> 72570224bb8f ("mips, bpf: Add JIT workarounds for CPU errata"), there
> is an ifdef that refers to a non-existing symbol WAR_R10000. Did you
> intend to refer to WAR_R10000_LLSC instead?

You are right, that is a typo. I will prepare a patch with a fix.

Thanks for catching!
Johan

>
> This issue was identified with the script ./scripts/checkkconfigsymbols.py.
>
> Best regards,
>> Lukas