netdev - Re: [PATCH net] net/smc: fix wrong list_del in smc_lgr_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d09ae3d-3715-ecf6-08d5-a9606bd4966d@linux.ibm.com>
Date:   Tue, 30 Nov 2021 17:20:19 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     Dust Li <dust.li@...ux.alibaba.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Tony Lu <tonylu@...ux.alibaba.com>,
        Wen Gu <guwen@...ux.alibaba.com>, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net/smc: fix wrong list_del in smc_lgr_cleanup_early

On 30/11/2021 16:17, Dust Li wrote:
> smc_lgr_cleanup_early() meant to deleted the link
> group from the link group list, but it deleted
> the list head by mistake.
> 
> This may cause memory corruption since we didn't
> remove the real link group from the list and later
> memseted the link group structure.

Great finding, thank you!

Acked-by: Karsten Graul <kgraul@...ux.ibm.com>