netdev - Re: [PATCH net-next v2 1/8] dt-bindings: ethernet-controller: support multiple PHY connection types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaalM87hNMv5jXhv@robh.at.kernel.org>
Date:   Tue, 30 Nov 2021 16:26:59 -0600
From:   Rob Herring <robh@...nel.org>
To:     Marek Behún <kabel@...nel.org>
Cc:     Jakub Kicinski <kuba@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Sean Anderson <sean.anderson@...o.com>,
        Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
        davem@...emloft.net, Russell King <rmk+kernel@...linux.org.uk>,
        devicetree@...r.kernel.org, Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next v2 1/8] dt-bindings: ethernet-controller:
 support multiple PHY connection types

On Tue, 23 Nov 2021 17:40:20 +0100, Marek Behún wrote:
> Sometimes, an ethernet PHY may communicate with ethernet controller with
> multiple different PHY connection types, and the software should be able
> to choose between them.
> 
> Russell King says:
>   conventionally phy-mode has meant "this is the mode we want to operate
>   the PHY interface in" which was fine when PHYs didn't change their
>   mode depending on the media speed
> This is no longer the case, since we have PHYs that can change PHY mode.
> 
> Existing example is the Marvell 88X3310 PHY, which supports connecting
> the MAC with the PHY with `xaui` and `rxaui`. The MAC may also support
> both modes, but it is possible that a particular board doesn't have
> these modes wired (since they use multiple SerDes lanes).
> 
> Another example is one SerDes lane capable of `1000base-x`, `2500base-x`
> and `sgmii` when connecting Marvell switches with Marvell ethernet
> controller. Currently we mention only one of these modes in device-tree,
> and software assumes the other modes are also supported, since they use
> the same SerDes lanes. But a board may be able to support `1000base-x`
> and not support `2500base-x`, for example due to the higher frequency
> not working correctly on a particular board.
> 
> In order for the kernel to know which modes are supported on the board,
> we need to be able to specify them all in the device-tree.
> 
> Change the type of property `phy-connection-type` of an ethernet
> controller to be an array of the enumerated strings, instead of just one
> string. Require at least one item defined.
> 
> Signed-off-by: Marek Behún <kabel@...nel.org>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Cc: devicetree@...r.kernel.org
> ---
>  .../bindings/net/ethernet-controller.yaml     | 94 ++++++++++---------
>  1 file changed, 49 insertions(+), 45 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>