netdev - Re: [PATCH] octeontx2-nicvf: Add netdev interface support for SDP VF devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC8NTUVmfNMNNJ3aT6=fB3S_9jb0XtyOt4s0VU8o1Q3RfQwY3Q@mail.gmail.com>
Date:   Mon, 29 Nov 2021 20:00:59 -0800
From:   Radha Mohan <mohun106@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        sgoutham@...vell.com,
        Prasun Kapoor <Prasun.Kapoor@...iumnetworks.com>,
        Satananda Burla <sburla@...vell.com>
Subject: Re: [PATCH] octeontx2-nicvf: Add netdev interface support for SDP VF devices

On Thu, Nov 25, 2021 at 7:08 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 24 Nov 2021 22:00:49 -0800 Radha Mohan wrote:
> > On Wed, Nov 24, 2021 at 7:27 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > > On Wed, 24 Nov 2021 18:21:04 -0800 Radha Mohan wrote:
> > > > This patch adds netdev interface for SDP VFs. This interface can be used
> > > > to communicate with a host over PCIe when OcteonTx is in PCIe Endpoint
> > > > mode.
> > >
> > > All your SDP/SDK/management interfaces do not fit into our netdev
> > > model of the world and should be removed upstream.
> >
> > SDP is our System DMA Packet Interface which sends/receives network
> > packets to NIX block. It is similar to CGX, LBK blocks but only
> > difference is the medium being PCIe. So if you have accepted that I
> > believe you can accept this as well.
>
> Nope, I have not accepted that. I was just too lazy to send a revert
> after it was merged.
I think you have misunderstood what I am saying. The currently merged
changes (not the ones what you were lazy about) support our networking
blocks NIX which has send/receive queues to transfer packets over CGX
(externally over the wire) and LBK (internally looping).
Now we are adding support for NIX to send/receive using SDP (over
PCIe). The earlier changes that you thought of rejecting (for reasons
unknown) are initial support and this change completes that.
Can you please elaborate on your outright rejection criteria only for
SDP ? Just saying I will not have XYZ support added just because I am
the maintainer now doesn't make a good argument.