netdev - Re: [PATCH net-next 02/12] iavf: Add change MTU message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211129165300.0cc4af5e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 29 Nov 2021 16:53:00 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Cc:     "patryk.malek@...el.com" <patryk.malek@...el.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>
Subject: Re: [PATCH net-next 02/12] iavf: Add change MTU message

On Mon, 29 Nov 2021 18:43:26 +0000 Nguyen, Anthony L wrote:
> On Wed, 2021-11-24 at 15:46 -0800, Jakub Kicinski wrote:
> > On Wed, 24 Nov 2021 09:16:42 -0800 Tony Nguyen wrote:  
> > > Add a netdev_info log entry in case of a change of MTU so that user
> > > is
> > > notified about this change in the same manner as in case of pf
> > > driver.  
> > 
> > Why is this an important piece of information, tho? Other major
> > vendors
> > don't print this.  
> 
> I was going to say this was to match the behaviour of our other
> drivers, however, after looking at the others, they are dev_dbgs. Would
> that change work for you?

Yes, dbg() would be better, thanks.