netdev - Re: [PATCH net-next 6/7] dt-bindings: net: Convert SYSTEMPORT to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1638369202.204682.1684346.nullmailer@robh.at.kernel.org>
Date:   Wed, 01 Dec 2021 08:33:22 -0600
From:   Rob Herring <robh@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Ray Jui <rjui@...adcom.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Scott Branden <sbranden@...adcom.com>,
        Rafał Miłecki <rafal@...ecki.pl>,
        bcm-kernel-feedback-list@...adcom.com,
        Doug Berger <opendmb@...il.com>
Subject: Re: [PATCH net-next 6/7] dt-bindings: net: Convert SYSTEMPORT to YAML

On Tue, 30 Nov 2021 20:12:27 -0800, Florian Fainelli wrote:
> Convert the Broadcom SYSTEMPORT Ethernet controller Device Tree binding
> to YAML.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  .../bindings/net/brcm,systemport.txt          | 38 ---------
>  .../bindings/net/brcm,systemport.yaml         | 83 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  3 files changed, 84 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/net/brcm,systemport.txt
>  create mode 100644 Documentation/devicetree/bindings/net/brcm,systemport.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,systemport.yaml: properties:interrupts: {'minItems': 2, 'maxItems': 3, 'items': [{'description': 'interrupt line for RX queues'}, {'description': 'interrupt line for TX queues'}, {'description': 'interrupt line for Wake-on-LAN'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,systemport.yaml: ignoring, error in schema: properties: interrupts
warning: no schema found in file: ./Documentation/devicetree/bindings/net/brcm,systemport.yaml
Documentation/devicetree/bindings/net/brcm,systemport.example.dt.yaml:0:0: /example-0/ethernet@...a0000: failed to match any schema with compatible: ['brcm,systemport-v1.00']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1561999

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.