netdev - RE: [EXT] Re: [PATCH net-next 2/2] net: stmmac: make stmmac-tx-timeout configurable in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB5785293BA211B0FD49EA40AFF0699@DB8PR04MB5785.eurprd04.prod.outlook.com>
Date:   Thu, 2 Dec 2021 10:28:48 +0000
From:   Xiaoliang Yang <xiaoliang.yang_1@....com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        Joakim Zhang <qiangqing.zhang@....com>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        Yannick Vignon <yannick.vignon@....com>,
        "boon.leong.ong@...el.com" <boon.leong.ong@...el.com>,
        "Jose.Abreu@...opsys.com" <Jose.Abreu@...opsys.com>,
        "mst@...hat.com" <mst@...hat.com>,
        "Joao.Pinto@...opsys.com" <Joao.Pinto@...opsys.com>,
        Mingkai Hu <mingkai.hu@....com>, Leo Li <leoyang.li@....com>
Subject: RE: [EXT] Re: [PATCH net-next 2/2] net: stmmac: make
 stmmac-tx-timeout configurable in Kconfig

Hi Heiner,

On Dec 02, 2021 at 16:13:20, Heiner Kallweit wrote:
> > stmmac_tx_timeout() function is called when a queue transmission
> > timeout. When Strict Priority is used as scheduling algorithms, the
> > lower priority queue may be blocked by a higher prority queue, which
> > will lead to tx timeout. We don't want to enable the tx watchdog
> > timeout in this case. Therefore, this patch make stmmac-tx-timeout
> configurable.
> >
> Your patch just disables the timeout handler, the WARN_ONCE() would still fire.
> And shouldn't this be a runtime setting rather than a compile-time setting?
> 
I tried to disable it in stmmac_tx_timeout() at runtime, the WARN_ONCE() will still be called from dev_watchdog() in sch_generic.c. It seems only when the timeout handler is NULL can disable the netdev watchdog up. So I did this in compile-time setting.

Regards,
Xiaoliang