netdev - RE: [v2 1/2] Docs/devicetree: add serdes-output-amplitude-mv to marvell.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR0602MB3666CB050086302087DB4184F7699@AM0PR0602MB3666.eurprd06.prod.outlook.com>
Date:   Thu, 2 Dec 2021 12:45:17 +0000
From:   Holger Brunck <holger.brunck@...achienergy.com>
To:     Marek Behún <kabel@...nel.org>,
        Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: RE: [v2 1/2] Docs/devicetree: add serdes-output-amplitude-mv to
 marvell.txt

> On Thu,  2 Dec 2021 09:05:26 +0100
> Holger Brunck <holger.brunck@...achienergy.com> wrote:
> 
> > This can be configured from the device tree. Add this property to the
> > documentation accordingly. This is a property of the port node, which
> > needs to be specified in millivolts
> >
> > CC: Andrew Lunn <andrew@...n.ch>
> > CC: Jakub Kicinski <kuba@...nel.org>
> > CC: Marek Behún <kabel@...nel.org>
> > Signed-off-by: Holger Brunck <holger.brunck@...achienergy.com>
> > ---
> >  Documentation/devicetree/bindings/net/dsa/marvell.txt | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > index 2363b412410c..9292b6f960df 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > @@ -46,6 +46,11 @@ Optional properties:
> >  - mdio?              : Container of PHYs and devices on the external MDIO
> >                         bus. The node must contains a compatible string of
> >                         "marvell,mv88e6xxx-mdio-external"
> > +- serdes-output-amplitude-mv: Configure the output amplitude of the serdes
> > +                           interface in millivolts. This option can be
> > +                              set in the ports node as it is a property of
> > +                              the port.
> > +    serdes-output-amplitude-mv = <210>;
> 
> The suffix should be millivolt, as can be seen in other bindings.
> 
> Also I think maybe use "tx" instead of "output"? It is more common to refere to
> serdes pairs as rx/tx instead of input/output:
> 
>   serdes-tx-amplitude-millivolt
> 

I can change that. The naming output-amplitude was chosen because the
register in the datasheet is named  "SGMII/FiberOutput Amplitude".
If I change it,  it would make sense that I also rename the
function and variable names to make it consistent IMHO.

Best regards
Holger