netdev - Re: [PATCH net-next] net: xfrm: drop check of pols[0] for the second time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211202141144.GT427717@gauss3.secunet.de>
Date:   Thu, 2 Dec 2021 15:11:44 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Jεan Sacren <sakiwit@...il.com>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <kuba@...nel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: xfrm: drop check of pols[0] for the second
 time

On Tue, Nov 30, 2021 at 12:03:12AM -0700, Jεan Sacren wrote:
> From: Jean Sacren <sakiwit@...il.com>
> 
> !pols[0] is checked earlier.  If we don't return, pols[0] is always
> true.  We should drop the check of pols[0] for the second time and the
> binary is also smaller.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   48395	    957	    240	  49592	   c1b8	net/xfrm/xfrm_policy.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   48379	    957	    240	  49576	   c1a8	net/xfrm/xfrm_policy.o
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>

Applied to ipsec-next, thanks!