netdev - Re: [PATCH RESEND net-next 5/5] net: wwan: core: make debugfs optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHNKnsQ1abmGQs5990dK0nN7zNnZG7=hPNJAX__VREw1=Ky2Vw@mail.gmail.com>
Date:   Fri, 3 Dec 2021 01:42:04 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Johannes Berg <johannes@...solutions.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        M Chetan Kumar <m.chetan.kumar@...el.com>,
        Intel Corporation <linuxwwan@...el.com>,
        Loic Poulain <loic.poulain@...aro.org>
Subject: Re: [PATCH RESEND net-next 5/5] net: wwan: core: make debugfs optional

On Thu, Dec 2, 2021 at 3:03 PM Leon Romanovsky <leon@...nel.org> wrote:
> On Thu, Dec 02, 2021 at 01:03:33AM +0300, Sergey Ryazanov wrote:
>> Ironically, I took your "don't over-engineer" argument and started
>> removing the IOSM specific configuration option when I realized that
>> the IOSM debugfs interface depends on relayfs and so it should select
>> the RELAY option. Without the IOSM debugfs option, we should either
>> place RELAY selection to an option that enables the driver itself, or
>> to the WWAN subsystem debugfs enabling option. The former will cause
>> the kernel inflation even with the WWAN debugfs interface disabled.
>> The latter will simply be misleading. In the end, I decided to keep
>> both config options in the V2.
>
> Something like this will do the trick.
>
> diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig
> index bdb2b0e46c12..ebb7292421a1 100644
> --- a/drivers/net/wwan/Kconfig
> +++ b/drivers/net/wwan/Kconfig
> @@ -85,6 +85,7 @@ config IOSM
>         tristate "IOSM Driver for Intel M.2 WWAN Device"
>         depends on INTEL_IOMMU
>         select NET_DEVLINK
> +        select RELAY if WWAN_DEBUGFS
>         help
>           This driver enables Intel M.2 WWAN Device communication.

Yes! This is exactly what I need to finally solve this puzzle. Thank you!

-- 
Sergey