netdev - Re: [PATCH net-next] net/mlx5: SF, silence an uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Dec 2021 06:28:07 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "leon@...nel.org" <leon@...nel.org>
CC:     Shay Drory <shayd@...dia.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Parav Pandit <parav@...dia.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "wanjiabing@...o.com" <wanjiabing@...o.com>,
        "jiapeng.chong@...ux.alibaba.com" <jiapeng.chong@...ux.alibaba.com>,
        Vu Pham <vuhuong@...dia.com>, Eli Cohen <elic@...dia.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: SF, silence an uninitialized variable
 warning

On Sun, 2021-11-28 at 11:26 +0200, Leon Romanovsky wrote:
> On Sat, Nov 27, 2021 at 05:19:53PM +0300, Dan Carpenter wrote:
> > This code sometimes calls mlx5_sf_hw_table_hwc_init() when
> > "ext_base_id"
> > is uninitialized.  It's not used on that path, but it generates a
> > static
> > checker warning to pass uninitialized variables to another
> > function.
> > It may also generate runtime UBSan  warnings depending on if the
> > mlx5_sf_hw_table_hwc_init() function is inlined or not.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@...dia.com>

applied to net-next-mlx5.