netdev - Re: [PATCH net-next 4/4] net: mscc: ocelot: set up traps for PTP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 03 Dec 2021 09:27:22 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Richard Cochran <richardcochran@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Po Liu <po.liu@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Antoine Tenart <atenart@...nel.org>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        "Y.B. Lu" <yangbo.lu@....com>, Rui Sousa <rui.sousa@....com>,
        "Allan W . Nielsen" <allan.nielsen@...rochip.com>
Subject: Re: [PATCH net-next 4/4] net: mscc: ocelot: set up traps for PTP
 packets

Hi Richard,

On Fri Nov 26 2021, Richard Cochran wrote:
> On Fri, Nov 26, 2021 at 05:01:13PM +0000, Vladimir Oltean wrote:
>
>> This, to me, sounds more like the bridge trapping the packets on br0
>> instead of letting them flow on the port netdevices, which is solved by
>> some netfilter rules? Or is it really a driver/hardware issue?
>> 
>> https://lore.kernel.org/netdev/20211116102138.26vkpeh23el6akya@skbuf/
>
> Yeah, thanks for the link.  I had seen it, but alas it came too late
> for me to try on actual working HW.  Maybe it fixes the issue.
>
> If someone out there has a Marvell switch, please try it and let us
> know...

I did some testing on a Marvell Topaz switch (mv88e6341). The Boundary
Clock over UDPv4/UDPv6 using Vladimir's netfilter rules doesn't
work. Even though I've successfully tested these rules on TI CPSW
(switchdev variant) and hellcreek.

However, BC over Layer 2 transport is also not really working well, as
the switch forwards PTP packets (instead of trapping?). Furthermore,
ptp4l reports loosing of timestamps when running on multiple switch
ports.

Tested with Linux v5.16.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)