netdev - Re: [PATCH net] inet: use #ifdef CONFIG_SOCK_RX_QUEUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b38c698-677b-a834-6f59-4134543393ed@gmail.com>
Date:   Fri, 3 Dec 2021 11:04:04 +0200
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.co.jp>,
        "eric.dumazet@...il.com" <eric.dumazet@...il.com>
Cc:     "daniel@...earbox.net" <daniel@...earbox.net>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kafai@...com" <kafai@...com>, "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] inet: use #ifdef CONFIG_SOCK_RX_QUEUE_MAPPING
 consistently



On 12/3/2021 2:21 AM, Kuniyuki Iwashima wrote:
> From:   Eric Dumazet <eric.dumazet@...il.com>
> Date:   Thu,  2 Dec 2021 14:42:18 -0800
>> Since commit 4e1beecc3b58 ("net/sock: Add kernel config
>> SOCK_RX_QUEUE_MAPPING"),
>> sk_rx_queue_mapping access is guarded by CONFIG_SOCK_RX_QUEUE_MAPPING.
>>
>> Fixes: 54b92e841937 ("tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> Acked-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
> 
> I missed the commit which was added while I was developing the SO_REUSEPORT
> series.
> 
> Thank you, Eric!
> 
> 
>> Cc: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
>> Cc: Daniel Borkmann <daniel@...earbox.net>
>> Cc: Martin KaFai Lau <kafai@...com>
>> Cc: Tariq Toukan <tariqt@...dia.com>
>> ---
>>   net/ipv4/inet_connection_sock.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
>> index f7fea3a7c5e64b92ca9c6b56293628923649e58c..62a67fdc344cd21505a84c905c1e2c05cc0ff866 100644
>> --- a/net/ipv4/inet_connection_sock.c
>> +++ b/net/ipv4/inet_connection_sock.c
>> @@ -721,7 +721,7 @@ static struct request_sock *inet_reqsk_clone(struct request_sock *req,
>>   
>>   	sk_node_init(&nreq_sk->sk_node);
>>   	nreq_sk->sk_tx_queue_mapping = req_sk->sk_tx_queue_mapping;
>> -#ifdef CONFIG_XPS
>> +#ifdef CONFIG_SOCK_RX_QUEUE_MAPPING
>>   	nreq_sk->sk_rx_queue_mapping = req_sk->sk_rx_queue_mapping;
>>   #endif
>>   	nreq_sk->sk_incoming_cpu = req_sk->sk_incoming_cpu;
>> -- 
>> 2.34.1.400.ga245620fadb-goog


Reviewed-by: Tariq Toukan <tariqt@...dia.com>
Thank you