netdev - Re: [PATCH net-next 07/11] net: hns3: add void before function which don't receive ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73861dd7-e766-f39f-1244-91012bf03983@huawei.com>
Date:   Fri, 3 Dec 2021 19:27:35 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <wangjie125@...wei.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lipeng321@...wei.com>, <chenhao288@...ilicon.com>
Subject: Re: [PATCH net-next 07/11] net: hns3: add void before function which
 don't receive ret



On 2021/12/3 19:15, Leon Romanovsky wrote:
> On Fri, Dec 03, 2021 at 05:20:55PM +0800, Guangbin Huang wrote:
>> From: Hao Chen <chenhao288@...ilicon.com>
>>
>> Add void before function which don't receive ret to improve code
>> readability.
>>
>> Signed-off-by: Hao Chen <chenhao288@...ilicon.com>
>> Signed-off-by: Guangbin Huang <huangguangbin2@...wei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c   | 2 +-
>>   drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> NAK,
> 
> Please stop to do it and fix your static analyzer.
> https://lore.kernel.org/linux-rdma/20211119172830.GL876299@ziepe.ca/
> 
> We don't add (void) in the kernel and especially for the functions that
> already declared as void.
> 
>     void devlink_register(struct devlink *devlink)
> 
> Thanks
> 
Ok, I remove this patch.
Thanks