netdev - Re: [iproute2-next 3/4] vdpa: Enable user to set mac address of vdpa device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cbabdb5-8c45-68e0-e60e-7bf16fe19f54@gmail.com>
Date:   Fri, 3 Dec 2021 10:05:24 -0700
From:   David Ahern <dsahern@...il.com>
To:     Parav Pandit <parav@...dia.com>, stephen@...workplumber.org,
        netdev@...r.kernel.org
Cc:     virtualization@...ts.linux-foundation.org, mst@...hat.com,
        jasowang@...hat.com
Subject: Re: [iproute2-next 3/4] vdpa: Enable user to set mac address of vdpa
 device

On 12/1/21 9:22 PM, Parav Pandit wrote:
> @@ -233,6 +254,15 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv,
>  
>  			NEXT_ARG_FWD();
>  			o_found |= VDPA_OPT_VDEV_MGMTDEV_HANDLE;
> +		} else if ((matches(*argv, "mac")  == 0) &&

use strcmp; we are not taking any more uses of matches() for parameters.


> +			   (o_all & VDPA_OPT_VDEV_MAC)) {
> +			NEXT_ARG_FWD();
> +			err = vdpa_argv_mac(vdpa, argc, argv, opts->mac);
> +			if (err)
> +				return err;
> +
> +			NEXT_ARG_FWD();
> +			o_found |= VDPA_OPT_VDEV_MAC;
>  		} else {
>  			fprintf(stderr, "Unknown option \"%s\"\n", *argv);
>  			return -EINVAL;