netdev - Re: [PATCH net,stable] phy: sfp: fix high power modules without diag mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211202175843.0210476e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 2 Dec 2021 17:58:43 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Bjørn Mork <bjorn@...k.no>, netdev@...r.kernel.org,
        照山周一郎 <teruyama@...ingboard-inc.jp>
Subject: Re: [PATCH net,stable] phy: sfp: fix high power modules without
 diag mode

On Tue, 30 Nov 2021 08:39:29 +0100 Bjørn Mork wrote:
> Commit 7cfa9c92d0a3 ("net: sfp: avoid power switch on address-change
> modules") changed semantics for high power modules without diag mode.
> We repeatedly try to read the current power status from the non-existing
> 0xa2 address, in the futile hope this failure is temporary:
> 
> [    8.856051] sfp sfp-eth3: module NTT              0000000000000000 rev 0000 sn 0000000000000000 dc 160408
> [    8.865843] mvpp2 f4000000.ethernet eth3: switched to inband/1000base-x link mode
> [    8.873469] sfp sfp-eth3: Failed to read EEPROM: -5
> [    8.983251] sfp sfp-eth3: Failed to read EEPROM: -5
> [    9.103250] sfp sfp-eth3: Failed to read EEPROM: -5
> 
> Eeprom dump:
> 
> 0x0000: 03 04 01 00 00 00 80 00 00 00 00 01 0d 00 0a 64
> 0x0010: 00 00 00 00 4e 54 54 20 20 20 20 20 20 20 20 20
> 0x0020: 20 20 20 20 00 00 00 00 30 30 30 30 30 30 30 30
> 0x0030: 30 30 30 30 30 30 30 30 30 30 30 30 05 1e 00 7d
> 0x0040: 02 00 00 00 30 30 30 30 30 30 30 30 30 30 30 30
> 0x0050: 30 30 30 30 31 36 30 34 30 38 20 20 00 00 00 75
> 0x0060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x0070: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x0080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x0090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 
> Previously we assumed such modules were powered up in the correct
> mode, continuing without further configuration as long as the
> required power class was supported by the host.
> 
> Revert to that behaviour, refactoring to keep the improved
> diagnostic messages.
> 
> Fixes: 7cfa9c92d0a3 ("net: sfp: avoid power switch on address-change modules")
> Reported-and-tested-by: 照山周一郎 <teruyama@...ingboard-inc.jp>
> Cc: Russell King <rmk+kernel@...linux.org.uk>
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Russell, any comments?